Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #39

Open
cdstanford opened this issue Jul 12, 2023 · 2 comments
Open

Performance improvements #39

cdstanford opened this issue Jul 12, 2023 · 2 comments
Labels
enhancement New feature or request roadmap-unplanned Ideas for future work

Comments

@cdstanford
Copy link
Collaborator

Performance isn't prohibitive for running on a single crate, so this is fine to revisit later, probably roadmap-v1.

Basically two things that would help would be

  • Loading rust-analyzer once for the entire workspace of several crates, rather than one instance per-crate
  • Caching results so that we don't have to recompute them for known versions of dependent crates -- This may come for free if we support pulling in a sanctioned existing policy from a database somewhere rather than always generating your own.
@cdstanford cdstanford added enhancement New feature or request roadmap-v1 Roadmap for v1.0 labels Jul 12, 2023
@cdstanford
Copy link
Collaborator Author

@DavidThien and @deian discussed on Thursday, maybe save the call graph to a file and the set of effects to a file, that way once a scan is run once it should not need to be run again

@cdstanford
Copy link
Collaborator Author

cdstanford commented Sep 6, 2023

IMO this is still roadmap-v1-- I'm not super enthusiastic, as we still have to run an initial scan and those should ideally be faster. I'm more in favor of prioritizing #45

@cdstanford cdstanford added roadmap-unplanned Ideas for future work and removed roadmap-v1 Roadmap for v1.0 labels Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap-unplanned Ideas for future work
Projects
None yet
Development

No branches or pull requests

1 participant