Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more context? #49

Closed
deian opened this issue Sep 6, 2023 · 4 comments
Closed

more context? #49

deian opened this issue Sep 6, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request roadmap-v0 On the current roadmap

Comments

@deian
Copy link
Member

deian commented Sep 6, 2023

image

I'd want to see how buff is used, but the default lines make it kind of hard; probably worth making this configurable

@deian
Copy link
Member Author

deian commented Sep 6, 2023

if you haven't looked at rand-0.8.5, I think it's a pretty great candidate

@cdstanford
Copy link
Collaborator

@DavidThien says it would be not hard to add another option to the user to show more context (e.g., show 10 more lines), this could be a good short term solution.
In favor?

There is also a CLI option to change the number of lines displayed: --lines-before and --lines-after

Worth keeping in mind, this may not be the best long term solution, eventual plan is to have something more like #12 and make it easier to navigate the actual code while doing an audit. But probably worth adding for now for v0?

@cdstanford cdstanford added enhancement New feature or request roadmap-v0 On the current roadmap labels Sep 6, 2023
@DavidThien
Copy link
Contributor

There's now an extra option during auditing to expand the context we show to the user. I also cleaned up the code while I was there, so we don't display the option to go the effect origin in situations it doesn't make sense.

@deian
Copy link
Member Author

deian commented Sep 13, 2023

awesome! ill give it another shot this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request roadmap-v0 On the current roadmap
Projects
None yet
Development

No branches or pull requests

3 participants