Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bloom release noetic incomplete #22

Open
v4hn opened this issue Jul 19, 2024 · 10 comments
Open

bloom release noetic incomplete #22

v4hn opened this issue Jul 19, 2024 · 10 comments

Comments

@v4hn
Copy link
Member

v4hn commented Jul 19, 2024

@mqcmd196 rightfully requested a new noetic release in #21 and I tried to do it.
Turns out I am missing permissions for the https://github.com/orgs/pr2-gbp organization for some reason and cannot push the release to bloom right now (see below)

I believe @k-okada is the only one who might have access there and can be contacted.
@mqcmd196 Please talk to him in my name to check if he can grant me the missing permissions.
It's possible he's missing the permissions to do that as well, though he can at least run the command that fails for me below.

@davefeilseifer If you happen to read this: You were the one who pushed the original package release for this repo to noetic in 2021 and I believe you have full admin permissions for the @pr2-gbp org (permissions are not public for it). If you can, please grant me permissions so I can push out noetic fixes. I met with @k-okada et al. a while ago and we started clearing out some pr2 packages since then.

❯ bloom-release pr2_self_test --rosdistro noetic
ROS Distro index file associate with commit '30e3197c9cc9a39642e3a73c814ed0d5bb8af9fd'
New ROS Distro index url: 'https://raw.githubusercontent.com/ros/rosdistro/30e3197c9cc9a39642e3a73c814ed0d5bb8af9fd/index-v4.yaml'
==> Fetching 'pr2_self_test' repository from 'https://github.com/pr2-gbp/pr2_self_test-release.git'
Cloning into '/tmp/tmpgbxqlshv'...
remote: Enumerating objects: 4107, done.
remote: Counting objects: 100% (718/718), done.
remote: Compressing objects: 100% (462/462), done.
remote: Total 4107 (delta 182), reused 716 (delta 182), pack-reused 3389
Receiving objects: 100% (4107/4107), 535.16 KiB | 12.45 MiB/s, done.
Resolving deltas: 100% (1215/1215), done.
==> Testing for push permission on release repository
==> git remote -v
origin  https://github.com/pr2-gbp/pr2_self_test-release.git (fetch)
origin  https://github.com/pr2-gbp/pr2_self_test-release.git (push)
==> git push origin master --dry-run
remote: Permission to pr2-gbp/pr2_self_test-release.git denied to v4hn.
@k-okada
Copy link
Contributor

k-okada commented Jul 19, 2024

@v4hn I am afraid that I also lost permission
@davefeilseifer ? @TheDash ? @sloretz ? @clalancette ? @nuclearsandwich ?could someone give us the permission?

k-okada@p51s:/tmp$ git clone [email protected]:pr2/pr2_self_test.git
Cloning into 'pr2_self_test'...
remote: Enumerating objects: 10082, done.
remote: Counting objects: 100% (125/125), done.
remote: Compressing objects: 100% (63/63), done.
remote: Total 10082 (delta 66), reused 111 (delta 60), pack-reused 9957
Receiving objects: 100% (10082/10082), 17.38 MiB | 8.03 MiB/s, done.
Resolving deltas: 100% (7058/7058), done.
k-okada@p51s:/tmp$ cd pr2_self_test/
k-okada@p51s:/tmp/pr2_self_test$ git push origin kinetic-devel
Everything up-to-date
k-okada@p51s:/tmp/pr2_self_test$ cd ..
k-okada@p51s:/tmp$ git clone [email protected]:pr2-gbp/pr2_self_test-release.git
Cloning into 'pr2_self_test-release'...
remote: Enumerating objects: 4107, done.
remote: Counting objects: 100% (718/718), done.
remote: Compressing objects: 100% (462/462), done.
remote: Total 4107 (delta 182), reused 716 (delta 182), pack-reused 3389
Receiving objects: 100% (4107/4107), 535.16 KiB | 1.14 MiB/s, done.
Resolving deltas: 100% (1215/1215), done.
k-okada@p51s:/tmp$ cd pr2_self_test-release/
k-okada@p51s:/tmp/pr2_self_test-release$ git push origin master
ERROR: Permission to pr2-gbp/pr2_self_test-release.git denied to k-okada.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@sloretz
Copy link

sloretz commented Jul 19, 2024

@gbiggs Does anyone at OSRF have write or admin access to https://github.com/pr2-gbp ?

@clalancette
Copy link

I also do not have permission for that organization.

@sloretz
Copy link

sloretz commented Jul 24, 2024

OOB Geoff doesn't know what happened to permissions on the pr2-gbp org either. I recommend contacting Github Support to try to get your access restored.

If that fails, as a last sort I would recommend cloning the release repo to a new org and updating ros/rosdistro accordingly.

@v4hn
Copy link
Member Author

v4hn commented Jul 25, 2024

@wjwwood: Would be great if you could check your permissions for the pr2-gbp org.
As per ros-gbp/rqt_pr2_dashboard-release#1 (comment) you had Owner access to the org in the past and granted it to @dirk-thomas and @k-okada as well, but at least Kei's permissions are gone.

I will contact gh support as well.

@v4hn
Copy link
Member Author

v4hn commented Jul 30, 2024

I contacted GH support, but they will not change ownership or grant access following their policies.
They will forward a message to the current anonymous owners, though my hopes are not very high that any of them is still active.

@sloretz @gbiggs Please nudge William through another channel to check whether he can grant access.

If there's no reply from the anonymous owners in a while I guess the annoying, but logical, next step is to migrate the rosdistro release repo entries to a different organization, possibly @ros-gbp (or @ros2-gbp although there will not be a ROS2 release of the packages in the near future).

@ahendrix
Copy link
Member

It appears I no longer have any access to the pr2-gbp repository either. Sorry.

@v4hn
Copy link
Member Author

v4hn commented Oct 18, 2024

Yesterday a community member discovered that the whole pr2-gbp organization was removed from github, invalidating various entries in the melodic/noetic sections of rosdistro.

It's highly frustrating that this step was taken by some anonymous person who retained ownership for an organization they were apparently not involved with anymore.

This leaves us no choice but to follow the next step described above if we want to repair the ROS releases.

the annoying, but logical, next step is to migrate the rosdistro release repo entries to a different organization, possibly https://github.com/ros-gbp (or https://github.com/ros2-gbp although there will not be a ROS2 release of the packages in the near future).

@sloretz I would appreciate guidance on whether we should ask for new repositories in ros-gbp, ros2-gbp, or host it independently again.

@k-okada

@UltronDestroyer
Copy link
Contributor

UltronDestroyer commented Oct 18, 2024

I am the owner of the repository - I woke up this morning and saw emails relating to this issue. I have contacted support to restore the repository. Once it is restored I will transfer ownership to (edit: all of you working on the pr2). I had no idea this was still being used by anyone. Sorry everyone.

@UltronDestroyer
Copy link
Contributor

Ownership is being transferred to @gbiggs. pr2-gbp has been restored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants