Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor login page to "pop" #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor login page to "pop" #255

wants to merge 2 commits into from

Conversation

lishaduck
Copy link
Member

Description

This PR includes changes to the login page in order to improve the user experience. The login page now pops back to the previous page after successful authentication, instead of pushing a new page onto the stack. This change ensures a smoother navigation flow for the user.

Type of Change

  • ♻️ Code refactor

@lishaduck lishaduck self-assigned this Nov 30, 2023
@lishaduck lishaduck added enhancement New feature or request dart Regards Dart code labels Nov 30, 2023
@lishaduck lishaduck force-pushed the update-login branch 2 times, most recently from 0e27a38 to 9a8faaf Compare December 13, 2023 05:07
@lishaduck lishaduck marked this pull request as ready for review January 3, 2024 03:22
@lishaduck lishaduck requested a review from a team as a code owner January 3, 2024 03:22
@lishaduck
Copy link
Member Author

lishaduck commented Jan 3, 2024

This works! I've tested, and it looks like the only issue is #264. Which is a big issue, but unrelated to this PR. I think this can merge. It's definitely not a regression, and might improve the UX.1

Footnotes

  1. You're welcome. It pains me, but UI isn't right for this. I guess UX is acceptable for a "flow."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Regards Dart code enhancement New feature or request
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant