Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds pareto tails for lognormal and kde #26

Merged
merged 10 commits into from
Aug 21, 2024

Conversation

john-p-ryan
Copy link
Contributor

This PR adds several methods for calculating the income distribution with a Pareto tail. These methods include a simultaneous estimate of the cutoff and pareto parameter via maximum likelihood, as well as 2 options for sequentially estimating the upper tail, with the body being estimated by lognormal or kernel density estimation.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 56.42%. Comparing base (10985c1) to head (634d1af).
Report is 10 commits behind head on main.

Files Patch % Lines
iot/inverse_optimal_tax.py 12.50% 35 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   72.81%   56.42%   -16.39%     
===========================================
  Files           3        3               
  Lines         103      140       +37     
===========================================
+ Hits           75       79        +4     
- Misses         28       61       +33     
Flag Coverage Δ
unittests 56.42% <12.50%> (-16.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-p-ryan
Copy link
Contributor Author

Added the notebook used to plot the income dists. The issue with very noisy g_z is resolved when the notebook is run in order. However, the discontinuity at the pareto cutoff is more pronounced. Work may be needed to smooth the derivative estimate at the cutoff.

@jdebacker
Copy link
Member

@john-p-ryan Please sync this branch to the master, which will help pass the CI tests on GH Actions. Thanks!

Updates to IOT PR PSLmodels#26 for formatting and testing
@jdebacker jdebacker merged commit 8fdcac2 into PSLmodels:main Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants