-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix files tags headers #23564
fix files tags headers #23564
Conversation
if there is need to expend the script, tell me |
src/drivers/distance_sensor/broadcom/afbrs50/Inc/api/argus_dfm.h
Outdated
Show resolved
Hide resolved
How about eliminating them instead? I can't imagine these actually provide value given how wrong they frequently are. I would also propose dropping per file author tags as well, that's what git blame is for. FYI @bresch |
I actually like the file name on the file it self. when it correct, it helps when you try to search the file references. about the authors names, it issue of credit, I thinks. |
cbc9786
to
3f8dccf
Compare
3f8dccf
to
694c46d
Compare
@dagar any reason not to merge it? there is need to change anything? |
I agree 100% https://youtube.com/clip/UgkxFrPo30esfK5g9chSNaljU-IMqmZrqVUR?si=R5nxZNwefYnWGVja |
@bresch what do you think about the file name? should we leave them? I prefer to keep, like I said it helps me to when I search for file references, to see the file itself on the search results |
@BazookaJoe1900 if you're using sublime text or vscode you can use ctrl + p to search for file names |
the original pr meant to fix the errors tags. I am without a firm opinion about the author tag. but it can be done after decision will be made about 'new' header format. BTW
on some places the name and the 'author' are mixed with the copyright: PX4-Autopilot/boards/mro/x21/nuttx-config/include/board.h Lines 5 to 6 in e4dd3f2
there are some 'inline' notes: PX4-Autopilot/src/lib/geo/geo.cpp Line 216 in e4dd3f2
I can 'clear' only the basic ones like this one: PX4-Autopilot/src/modules/mc_att_control/mc_att_control_main.cpp Lines 38 to 45 in e4dd3f2
|
You could leave the file names if you find them useful. The problem is -as shown by this PR- ppl tend to copy-paste the header from another file or change the name of the file and often forget to update it. Removing the author names starting with |
Solved Problem
many files has wrong file tag on their header description.
Solution
I wrote script to find and fix the files