Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gz-garden from Ubuntu Installation as it reached EOL #24089

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Perrrewi
Copy link
Contributor

@Perrrewi Perrrewi commented Dec 10, 2024

Solved Problem

Test coverage

  • not yet tested

@Perrrewi Perrrewi requested review from beniaminopozzan and MaEtUgR and removed request for beniaminopozzan December 10, 2024 15:50
@Perrrewi Perrrewi self-assigned this Dec 10, 2024
@hamishwillee
Copy link
Contributor

Sounds sensible. We already purged most of it in #23603

Note, there are a few minor docs mentions left of gazebo garden, specifically in

Copy link
Member

@MaEtUgR MaEtUgR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Perrrewi for addressing this, I wasn't aware.

JFYI @asifpatankar this was added in #23203 I hope it's still working on Linux Mint if the version is based on an Ubuntu LTS. It's hard for us to maintain such specific cases since we are not using that distribution.

@MaEtUgR MaEtUgR merged commit fc6c678 into main Dec 12, 2024
60 checks passed
@MaEtUgR MaEtUgR deleted the pernilla/remove-gz-garden-due-to-EOL branch December 12, 2024 14:11
@Perrrewi Perrrewi changed the title Draft: Remove gz-garden from Ubuntu Installation as it reached EOL Remove gz-garden from Ubuntu Installation as it reached EOL Dec 12, 2024
@dakejahl
Copy link
Contributor

I'm struggling to build main, seems like garden is not fully purged. Does anyone know how to purge garden and install harmonic? I've tried the standard apt-get remove/purge and installed gz-harmonic

/home/jake/code/jake/PX4-Autopilot/src/modules/simulation/gz_bridge/GZBridge.hpp:71:10: fatal error: gz/msgs/air_speed.pb.h: No such file or directory
   71 | #include <gz/msgs/air_speed.pb.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~

@dakejahl
Copy link
Contributor

I think my cmake was still cached even after deleting my build directory. Not sure. Anyway this fixes the issue
#24101

@asifpatankar
Copy link

#24101 worked smoothly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants