[x500_monocam_down] added rangefinder #51
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
requested changes
Jul 26, 2024
There was a problem hiding this comment.
We already have implementation for the prior in https://github.com/PX4/PX4-SITL_gazebo-classic/blob/main/src/gazebo_opticalflow_plugin.cpp Probable we can reuse some parts of it?
| <joint name="RangeFinderJoint" type="fixed"> | ||
| <parent>base_link</parent> | ||
| <child>rangefinder/base_link</child> | ||
| <pose relative_to="base_link">0.05 0 0.1 0 1.5707 0</pose> |
There was a problem hiding this comment.
I would probably add a dedicated model for optical flow.
There was a problem hiding this comment.
you're saying combine range finder and camera? Or a new x500 model?
|
oh yeah totally forgot https://github.com/PX4/PX4-OpticalFlow was a thing, didn't realize this was here! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on adding optical flow to sim, I could use some help with review/testing. The big tiled image is to provide texture for finding keypoints... need to figure out how to use something simpler.
PX4/PX4-Autopilot#23456