Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WALLS: remove walls below groundplane #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Claudio-Chies
Copy link
Contributor

Purely aesthetic, the walls went down below the ground plane, with this PR i'm changing this so they are only at groundlevel and above.

@Claudio-Chies Claudio-Chies force-pushed the pr-walls branch 7 times, most recently from fbac243 to 70cd31d Compare October 3, 2024 12:57
@Claudio-Chies Claudio-Chies marked this pull request as ready for review October 3, 2024 13:01
@Claudio-Chies
Copy link
Contributor Author

@Jaeyoung-Lim Any pointers why the SDF Parsing might be failing?

  • I checked my structure, which is the same as the other worlds.
  • I checked if the intersecting boxes are the problem, which it's not.
  • incorrect indentation also seems to not be the problem.
    The test is just if the sdf::readFile function works or not. when loading the world with gazebo, everything works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant