Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 4 Door to New Levels #27

Open
mrwnphs opened this issue Jul 15, 2024 · 1 comment
Open

Chapter 4 Door to New Levels #27

mrwnphs opened this issue Jul 15, 2024 · 1 comment

Comments

@mrwnphs
Copy link

mrwnphs commented Jul 15, 2024

The description of the process to add a door to get to new levels is incomplete. In the script you provide to spawn_items, you must check to see whether the item type is a door or not. Unfortunately, you do not describe how to set the type for the door. When it came to the cherry and the gem, you set the item type yourself without explaining how to do it.

Also, I'm not entirely sure why we need both a door scene and a door item to get to the next level. I think it would be simpler to just add a door scene to each level- the designer will have to place the door as an item anyway, so I don't see the problem with adding the door to each level scene. Having to add an item that causes a door scene to be instantiated is fairly abstract and I'm not sure that it's necessary. I will try to play around with this myself and see if I can get it to work.

In the mean time, it would be nice to explain to the reader how to add the special type to the door in the TileSet so that the spawn_items script can work correctly.

@packt-simrana
Copy link
Collaborator

Hi mrwnphs,

Thank you for taking the time to share your detailed feedback on the book. I appreciate your insights and suggestions.

Regarding your point about setting the type for the door and explaining it in the script, I understand the confusion and the need for more clarity. Your suggestion to simplify the process by adding a door scene to each level directly, instead of having both a door scene and a door item, is indeed an interesting approach. This feedback is valuable, and I will pass it on to the team for consideration in future revisions of the book.

@cbscribe, could you please share your thoughts on this feedback and the suggested approach? Your expertise will be greatly appreciated.

Thank you once again for your thoughtful feedback, and I encourage you to continue experimenting and sharing your findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants