Provider crashes when target instance is Panorama instead of Firewall (bpg resources, ike gateway and tunnel interface)

[dga-nagra]

Describe the bug

The provider crashes for many resources when the client points on Panorama server.

As said in the logs, this is a crash on the provider side.
The resources concerned is "panos_bgp",
But this seems to impact other resources indirectly:

• panos_panorama_ike_gateway
• panos_panorama_tunnel_interface
• panos_panorama_bgp_import_rule_group
• panos_panorama_bgp_export_rule_group

The line causing the crash is this one:
https://github.com/PaloAltoNetworks/terraform-provider-panos/blob/master/panos/resource_bgp.go#L191

Expected behavior

The provider should either:

• Support Panorama Server as the target
• Give a clean feedback to the user that only Firewall devices can be targeted (this should also be documented)

Current behavior

Terraform crashes with an unclear message

NOTE: This only happens on the "terraform apply".

Possible solution

Check the instance type and:

• Adapt the behavior accordingly
• or display a clean error message and stop the provider gracefully.

Steps to reproduce

1. Configure the panos provider to point on a Panorama instance
2. Use any of the resources mentioned above (e.g. panos_bgp
3. Run "terraform apply"

Screenshots

See above

Context

We are not able to manage our resources using terraform, which is a big inconvenience.

Your Environment

• Version used: panos 1.11.1
• Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3): None
• Operating System and version (desktop or mobile): terraform:1.6.6 docker image
• Link to your project: private repository