Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: add embedded python release. #226

Open
1 task done
silveroxides opened this issue Jan 1, 2025 · 3 comments
Open
1 task done

[Feature Request]: add embedded python release. #226

silveroxides opened this issue Jan 1, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@silveroxides
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

I made an embedded python release and uploaded on my fork of this repo for testing. The archive is set up with this repo as remote. It is not perfect but the initial module installation when first run will automatically correct these. I believe it would be a good addition to ease the install process for the end user if this was available. link to the release

Proposed workflow

  1. Go to release
  2. Download the archive
  3. Double check the modules and structure
  4. Respond to this issue if any changes should be made by me
  5. Repackage the archive if changes has beeen made (Settings in 7zip: LZMA2 Level 7 ('Normal))
  6. Upload final embedded python archive to releases

Additional information

No response

@silveroxides silveroxides added the enhancement New feature or request label Jan 1, 2025
@lespaul64
Copy link

lespaul64 commented Jan 4, 2025

Hi, about a month ago i tried to make reforge portable too, see #198 and today i'm still using that portable reforge.

What bother me is this line in webui-user.bat:
set GIT=

The embedded python is working fine on portable reforge.

@silveroxides
Copy link
Author

@lespaul64 The portable I use have not faced any issues so far. Is the GIT issue related to installation of extensions or anything like that?
Because I test ran it and during installation it seemed to work fine but you might be right.

@silveroxides
Copy link
Author

@lespaul64
I just checked. set GIT= should not affect it since run.bat calls environment.bat which does set PATH=%DIR%\git\bin;%DIR%\python;%DIR%\python\Scripts;%PATH%

That sets the portable git binary ahead of any global one in the PATH system environment variable making it priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants