Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: Fail to retrieve from bank when transferring fractional to self #9

Open
mathdroid opened this issue Feb 11, 2024 · 1 comment
Open

DRAFT: Fail to retrieve from bank when transferring fractional to self #9

mathdroid opened this issue Feb 11, 2024 · 1 comment

Comments

@mathdroid
Copy link
Collaborator

Traces:

Traces:
  [3813425] Erc404MinimalTest::test_erc721Storage_retrieveFromBank(76, 0xd38171555580273cEa88FA0cD3622F9bb94a236B, 0xd38171555580273cEa88FA0cD3622F9bb94a236B) 
    ├─ [0] VM::assume(true) [staticcall]
    │   └─ ← ()
    ├─ [0] VM::assume(true) [staticcall]
    │   └─ ← ()
    ├─ [0] VM::assume(true) [staticcall]
    │   └─ ← ()
    ├─ [2587] MinimalERC404::whitelist(0xd38171555580273cEa88FA0cD3622F9bb94a236B) [staticcall]
    │   └─ ← false
    ├─ [587] MinimalERC404::whitelist(0xd38171555580273cEa88FA0cD3622F9bb94a236B) [staticcall]
    │   └─ ← false
    ├─ [0] VM::assume(true) [staticcall]
    │   └─ ← ()
    ├─ [0] VM::prank(0x0000000000000000000000000000000000000001) 
    │   └─ ← ()
    ├─ [3771449] MinimalERC404::mintERC20(0xd38171555580273cEa88FA0cD3622F9bb94a236B, 76000000000000000000 [7.6e19], true) 
    │   ├─ emit ERC20Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, amount: 76000000000000000000 [7.6e19])
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 1)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 2)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 3)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 4)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 5)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 6)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 7)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 8)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 9)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 10)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 11)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 12)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 13)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 14)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 15)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 16)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 17)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 18)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 19)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 20)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 21)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 22)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 23)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 24)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 25)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 26)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 27)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 28)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 29)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 30)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 31)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 32)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 33)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 34)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 35)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 36)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 37)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 38)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 39)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 40)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 41)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 42)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 43)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 44)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 45)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 46)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 47)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 48)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 49)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 50)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 51)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 52)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 53)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 54)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 55)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 56)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 57)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 58)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 59)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 60)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 61)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 62)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 63)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 64)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 65)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 66)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 67)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 68)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 69)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 70)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 71)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 72)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 73)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 74)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 75)
    │   ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 76)
    │   └─ ← ()
    ├─ [0] VM::prank(0xd38171555580273cEa88FA0cD3622F9bb94a236B) 
    │   └─ ← ()
    ├─ [42702] MinimalERC404::transfer(0xd38171555580273cEa88FA0cD3622F9bb94a236B, 100000000000000000 [1e17]) 
    │   ├─ emit ERC20Transfer(from: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, amount: 100000000000000000 [1e17])
    │   ├─ emit ERC721Transfer(from: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, to: 0x0000000000000000000000000000000000000000, id: 76)
    │   └─ ← true
    ├─ [2608] MinimalERC404::balanceOf(MinimalERC404: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f]) [staticcall]
    │   └─ ← 0
    ├─ [463] MinimalERC404::erc721TokensBankedInQueue() [staticcall]
    │   └─ ← 1
    ├─ [0] VM::expectEmit(false, false, false, false) 
    │   └─ ← ()
    ├─ emit ERC20Transfer(from: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, amount: 100000000000000000 [1e17])
    ├─ [0] VM::expectEmit(false, false, false, false) 
    │   └─ ← ()
    ├─ emit ERC721Transfer(from: 0x0000000000000000000000000000000000000000, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, id: 76)
    ├─ [0] VM::prank(0xd38171555580273cEa88FA0cD3622F9bb94a236B) 
    │   └─ ← ()
    ├─ [26782] MinimalERC404::transfer(0xd38171555580273cEa88FA0cD3622F9bb94a236B, 100000000000000000 [1e17]) 
    │   ├─ emit ERC20Transfer(from: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, to: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, amount: 100000000000000000 [1e17])
    │   ├─ emit ERC721Transfer(from: 0xd38171555580273cEa88FA0cD3622F9bb94a236B, to: 0x0000000000000000000000000000000000000000, id: 75)
    │   └─ ← true
    ├─ [606] MinimalERC404::erc20BalanceOf(0xd38171555580273cEa88FA0cD3622F9bb94a236B) [staticcall]
    │   └─ ← 76000000000000000000 [7.6e19]
    ├─ [715] MinimalERC404::ownerOf(76) [staticcall]
    │   └─ ← "NotFound()"
    └─ ← "NotFound()"
    ```
@mathdroid
Copy link
Collaborator Author

mathdroid commented Feb 11, 2024 •
edited
Loading

Waiting for #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mathdroid