Handling of identical method signatures with different static
ness while migrating
#11
Labels
enhancement
New feature or request
static
ness while migrating
#11
Currently, there is no marker for the
static
-ness of a method in the output files. This causes a slight issue when performing a migration across Minecraft versions of the mapping data, if a method retains the same method signature across both versions (usually, the intermediate mapping format in use assigns the same identifier) but changes instatic
-ness.This causes the mapped parameter indexes to be off by one from the actual indexes (due to the implicit first parameter index being occupied in non-
static
methods), possibly causing validation errors and loss of that mapped parameter.An example of this is https://github.com/ParchmentMC/Parchment/blob/96b967494dd830bb65a1ee18eeaf6ca6833d6585/data/net/minecraft/client/renderer/entity/EntityRenderDispatcher.mapping#L53-L57, specifically
EntityRenderDispatcher#renderHitbox
. This method was previously non-static
in 1.16 but then became astatic
method in 1.17, which explains why the parameters, although correct, are off by one index.The text was updated successfully, but these errors were encountered: