Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeDoDe doesn't produce absolute confidence? #31

Open
nnop opened this issue Apr 24, 2024 · 2 comments
Open

DeDoDe doesn't produce absolute confidence? #31

nnop opened this issue Apr 24, 2024 · 2 comments

Comments

@nnop
Copy link

nnop commented Apr 24, 2024

Hi, thanks for the great work.

I found that DeDoDe calculates the Softmax confidence over the entire image and the max resulting confidence is very low, e.g. 0.00095387973 in my test.

keypoint_p = keypoint_logits.reshape(B, K*H*W).softmax(dim=-1).reshape(B, K, H*W).sum(dim=1)

So how can I set an absolute confidence threshold (for example: 0.1) to filter out non salient area?

@Parskatt
Copy link
Owner

I don't recommend doing that. The filtering is done by topk. If you want to set a threshold, perhaps you can set it based on the max over the image, e.g.., t= 0.01 * maxprob

@nnop
Copy link
Author

nnop commented Apr 24, 2024

Thanks for your suggestion. I think that's practial.

Another question about the params.
Why set use_nms=False in detect(). Wouldn't nms help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants