Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce AllEndpointsSupportDelayedDelivery in a safe manner #370

Open
WojcikMike opened this issue May 1, 2017 · 1 comment
Open

Comments

@WojcikMike
Copy link
Contributor

WojcikMike commented May 1, 2017

This setting was removed in 4.3.1, due to #367.

In order to support legacy endpoints which do not declare the delay infrastructure, a delayed message sender declares the binding between the delay infrastructure and the receiving endpoint queue before every send and this extra call to the broker may have significant performance impact. This setting removes that extra call and is safe to use when it is known that the receiving endpoint supports delayed delivery and has already made the required declaration. Before attempting to solve this issue, we should measure the performance impact of the extra call before each send to see if it is indeed significant.

Another option is to make the call once, on the first send, and then skip the call on the next send, by recording that first call in memory.

@WojcikMike
Copy link
Contributor Author

An idea how to solve it was raised during maintainer sync. We could use deadletter exchange to move all undelivered messages to the predefined queue. This queue would be consumed by every endpoint and would throw exception on that message moving it into ServiceControl error queue. That would allow for the end user to retry the message after the receiving endpoint is turned on.

@ramonsmits ramonsmits modified the milestone: 5.3.0 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants