Change remaining items to match naming conventions

[bording]

#384 adjusted as much as possible to follow the naming conventions, but there are some things that couldn't be changed without introducing breaks of some kind. We should consider adjusting these as well when we can.

Plan of attack

• Assembly name - Fix naming #424
• Product and Title assembly attributes - Fix naming #424
• Solution name - Fix naming #424
• Repo name - Rename repo to NServiceBus.Transport.RabbitMQ #433
• CI project name - has knock on effects due to the build templates, Octopus,etc., so not worth it
• NuGet package ID - cost outweighs benefit, use convention for new packages only

[adamralph]

FYI I changed the CI project name, which meant I had to override the inherited GitUrl parameters to point to the "wrongly" named repo, and also, for the regular build (the old non-.NET Core build which is paused), I had to override the SolutionPath parameter to point the "wrongly" named NServiceBus.RabbitMQ.sln.

[adamralph]

@Particular/rabbitmq-transport-maintainers I've crossed out the "NuGet package ID" item since it seems it's best to keep it as-is, and only use the convention for new packages.

[bording]

Is there anything else here that we actually want to change? I see Repo name is still unchecked, though I'm wondering if changing that will also have impacts on CI that aren't worth it?

[adamralph]

As discussed, we'll leave the repo name as-is for now. Raised #433 for that.