Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash due to possible connectivity issue. #920

Open
Holit opened this issue Nov 1, 2023 · 0 comments
Open

Crash due to possible connectivity issue. #920

Holit opened this issue Nov 1, 2023 · 0 comments

Comments

@Holit
Copy link

Holit commented Nov 1, 2023

Describe the bug
I am unable to launch the game using SMAPI. I have re-installed and verified all the files from Steam. There are no mods installed except for internal-mods, and it still doesn't work.
A clear and concise description of what the bug is. Provide any other details you think might be relevant here.

To Reproduce
This issue can be reproduced by launching the executable using either Steam or the console.

Log file
https://smapi.io/log/fab976030b3743d4bdcfc0e1be785667

More information
According to the exception log, it seems that some code around SMAPI\Framework\SCore.cs:line:1542 may be causing the problem. I launched this program under a complex network connectivity situation in China, where:

  • I am unable to directly access github.com due to the Great Firewall (GFW) under normal network conditions.
  • My computer has TAP enabled, which means that all traffic from my host passes through a virtual network gateway and is sent to an intermittent server to proxy traffic to the correct address.
  • Other programs do not have any problems connecting to Github.com, and they do not require any extra configuration such as proxies.

I've analyzed the code and suspect that this issue may be related to some unclosed sockets. I say this because I found that this exception (overlapped) is triggered by SMAPI\Framework\SCore.cs:line:1567, which is inside the exception branch, and the previously caught exception is related to HttpRequestException. I attempted to resolve the issue by disabling update checking by adjusting the code, and the program worked fine (by adding a 'return' statement above all the code). I stopped my analysis at this point because I am not very familiar with async programming.

First exception is raised by HttpRequestException
image
Second exception is raised by this.Monitor.Log(
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant