Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount paths should be required when starting Robustar with robustar.sh script. #180

Open
PaulCCCCCCH opened this issue Jul 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@PaulCCCCCCH
Copy link
Owner

Thanks @zehongl4 for pointing out this issue.

Users can either start Robustar with the launcher or the scripts. If users want to start with a script, they can follow the templates provided in scripts/example.sh, which calls scripts/robustar.sh with a bunch of parameters. However, they sometimes miss some of the parameters (e.g., they specified all the paths except the training path -t, which is not unlikely because there are so many paths to mount).

The problem is, in robustar.sh, we define default values for many parameters see here. When some input parameters are missing, these default values will cause errors that look like cannot bind with relative path, which makes users confused.

A solution is to remove the default values and make these parameters required. If any of them are missing, a prompt will be displayed.

@PaulCCCCCCH PaulCCCCCCH added the enhancement New feature or request label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant