--timed + --order selection doesn't seem to work

[cprn]

I'm trying to unlock all achievements for a game with random spacing but in a specific order. It seems the manager assigns a random time between 0 and specified --amount to each achievement, effectively changing the order in which they're supposed to be unlocked.

Am I doing something wrong or is this a bug?

❯ samrewritten 24420 --timed --amount 258 --units minutes --spacing random --unlock ACH_REACHED_OPEN_WATERS,ACH_COMBO_EATER,ACH_REACHED_THE_VEIL,ACH_ROMANCE,ACH_REACHED_SPRITE_CAVE,ACH_DEFEAT_PRIESTS,ACH_DEFEAT_ROCKCRAB,ACH_DEFEAT_MANTISSHRIMP,ACH_DEFEAT_MERGOG,ACH_HIGH_DIVE,ACH_THE_FROZEN_VEIL,ACH_DEFEAT_OCTOMUN,ACH_MOMMY_AND_DADDY,ACH_RESCUED_ALL_SOULS,ACH_BELLY_OF_THE_WHALE,ACH_AQUIRE_ALL_SONGS,ACH_DEFEAT_KINGJELLY,ACH_KILLED_THE_COWARD,ACH_HEALTHY,ACH_ATE_A_PARROT,ACH_MASS_TRANSIT,ACH_BUCKING_BRONCO,ACH_FLUNG_A_MONKEY,ACH_ALEK_AND_DAREC,ACH_EXPLORER,ACH_DISCOVER_ALL_RECIPES,ACH_SPEED_RACER --order selection
Modify achievement ACH_REACHED_OPEN_WATERS in 2988 seconds (or 49.8 minutes or 0.83 hours)
Modify achievement ACH_COMBO_EATER in 2151 seconds (or 35.85 minutes or 0.5975 hours)
Modify achievement ACH_REACHED_THE_VEIL in 1188 seconds (or 19.8 minutes or 0.33 hours)
Modify achievement ACH_ROMANCE in 9606 seconds (or 160.1 minutes or 2.66833 hours)
Modify achievement ACH_REACHED_SPRITE_CAVE in 11154 seconds (or 185.9 minutes or 3.09833 hours)
Modify achievement ACH_DEFEAT_PRIESTS in 3673 seconds (or 61.2167 minutes or 1.02028 hours)
Modify achievement ACH_DEFEAT_ROCKCRAB in 12167 seconds (or 202.783 minutes or 3.37972 hours)
Modify achievement ACH_DEFEAT_MANTISSHRIMP in 14321 seconds (or 238.683 minutes or 3.97806 hours)
Modify achievement ACH_DEFEAT_MERGOG in 14077 seconds (or 234.617 minutes or 3.91028 hours)
Modify achievement ACH_HIGH_DIVE in 442 seconds (or 7.36667 minutes or 0.122778 hours)
Modify achievement ACH_THE_FROZEN_VEIL in 9134 seconds (or 152.233 minutes or 2.53722 hours)
Modify achievement ACH_DEFEAT_OCTOMUN in 7235 seconds (or 120.583 minutes or 2.00972 hours)
Modify achievement ACH_MOMMY_AND_DADDY in 14667 seconds (or 244.45 minutes or 4.07417 hours)
Modify achievement ACH_RESCUED_ALL_SOULS in 5063 seconds (or 84.3833 minutes or 1.40639 hours)
Modify achievement ACH_BELLY_OF_THE_WHALE in 12905 seconds (or 215.083 minutes or 3.58472 hours)
Modify achievement ACH_AQUIRE_ALL_SONGS in 6819 seconds (or 113.65 minutes or 1.89417 hours)
Modify achievement ACH_DEFEAT_KINGJELLY in 8002 seconds (or 133.367 minutes or 2.22278 hours)
Modify achievement ACH_KILLED_THE_COWARD in 885 seconds (or 14.75 minutes or 0.245833 hours)
Modify achievement ACH_HEALTHY in 15002 seconds (or 250.033 minutes or 4.16722 hours)
Modify achievement ACH_ATE_A_PARROT in 13582 seconds (or 226.367 minutes or 3.77278 hours)
Modify achievement ACH_MASS_TRANSIT in 13916 seconds (or 231.933 minutes or 3.86556 hours)
Modify achievement ACH_BUCKING_BRONCO in 4667 seconds (or 77.7833 minutes or 1.29639 hours)
Modify achievement ACH_FLUNG_A_MONKEY in 3042 seconds (or 50.7 minutes or 0.845 hours)
Modify achievement ACH_ALEK_AND_DAREC in 12032 seconds (or 200.533 minutes or 3.34222 hours)
Modify achievement ACH_EXPLORER in 1667 seconds (or 27.7833 minutes or 0.463056 hours)
Modify achievement ACH_DISCOVER_ALL_RECIPES in 7782 seconds (or 129.7 minutes or 2.16167 hours)
Modify achievement ACH_SPEED_RACER in 15266 seconds (or 254.433 minutes or 4.24056 hours)
Modifying next achievement in 442 seconds (or 7.36667 minutes or 0.122778 hours)
It looks like the server before me did not shutdown properly.
[S_API] SteamAPI_Init(): Loaded '/home/cg/.local/share/Steam/linux64/steamclient.so' OK.
Setting breakpad minidump AppID = 24420
Steam_SetMinidumpSteamID:  Caching Steam ID:  76561198090757837 [API loaded no]
^CQuitting cli idling
Read pipe encountered fatal error.

If this isn't a bug but a lack of feature, i.e. there's a need for a dedicated scheduler that solves --order selection, I can familiarize myself with the codebase and send an MR over the weekend.

[PaulCombal]

Hey man I don't know I wasn't the one implementing this part. I've quickly gone through the repo and the code seems really easy to understand without any prior knowledge, so I'm sure you can contribute!

The logic for that part lies around here: https://github.com/PaulCombal/SamRewritten/blob/master/src/cli/cli_funcs.cpp#L301

If you do want to PR, please explain what the previous behavior was, what the new behavior is, and maybe leave an option to have both if this wasn't a bug.

Sorry like I said I don't have much time right now to work on this project in a near future anymore, but if you need help, ask away!! :)