Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format_weather() fills empty times the errors when NA values detected #15

Open
PaulMelloy opened this issue Sep 1, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@PaulMelloy
Copy link
Owner

format_weather() automatically will fill any missing times. when filling time gaps it will fill the temperatures, rain and wind as NA.
Then it checks the data and errors because there are NA values.

The following needs to be implemented for informed troubleshooting

  1. Error messages need to specify the possibility of missing data
  2. Use the impute functions to automatically fill data on request
  3. Warning message to user so they know when data is missing
@PaulMelloy PaulMelloy added the enhancement New feature or request label Nov 19, 2024
@PaulMelloy PaulMelloy self-assigned this Nov 19, 2024
@PaulMelloy PaulMelloy added this to the CRAN release milestone Nov 19, 2024
@PaulMelloy
Copy link
Owner Author

format weather should only format in UTC to ensure daylight savings does not introduce errors. Currently this is done to an extent, however perhaps more tests need to be made to ensure it is done adequatley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant