[Deploy] CI/CD 구축 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
|
진짜 많이 알아보고 비교하고 생각한 보람이 있다!!! 이 많은 걸 뚝딱 해내다니 |
hojeong2747
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
주석 달아준 거 너무 좋아!
도커만 쓸 때랑 비교했을 때 key 값 설정 많이 안 해도 되니까 보기 편한 장점도 있는 듯 ㅎㅎ
There was a problem hiding this comment.
맞아 AWS 설정이 조금 필요하긴 하지만 secret key를 많이 이용 안 해서 관리하기도 편하고 좋은 듯!
There was a problem hiding this comment.
deploy.sh 스크립트를 처음 보는데 여기도 주석 꽤 자세히 달려 있어서 읽기 편리하다!
여기서 로깅 기능 함수로 정의해서 쓰면 좀 더 깔끔한 스크립트가 될 것 같긴 한데 지금도 많진 않으니 좋아 ㅎㅎ
There was a problem hiding this comment.
shell script 문법을 조금 익혀두고 바꿔도 좋을 듯! health check랑 같이 바꾸면 되겠다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #3
📝 작업 내용
CI/CD 구축
💬 리뷰 요구 사항