Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on the README #1

Open
jgfrancisco opened this issue Jul 18, 2016 · 2 comments
Open

Comments on the README #1

jgfrancisco opened this issue Jul 18, 2016 · 2 comments

Comments

@jgfrancisco
Copy link

  • On 3. Execute Checkout API
    • typo on comment for itemAmountDetailsOptions
  • On Retrieve Checkout
    • What will happen if I create 2 checkout (call checkout.execute(callback) twice). Which one will be retrieved by: checkout.retrieve(callback)
  • Why is there a Payments header?
  • On the customization example
    • maybe use dummy example for the logo and icon URLs
@haroldcalayan
Copy link
Contributor

Hi @jgfrancisco,

Thanks for your evaluation.
These are my actions in your concerns:

  • On 3. Execute Checkout API: I just put the comment "Construct item here" in the correct position.
  • On Retrieve Checkout - What will happen if I create 2 checkout (call checkout.execute(callback) twice). Which one will be retrieved by: checkout.retrieve(callback): You will get the checkout object of the last id that you get after execute.
  • Why is there a Payments header?: I just removed this.
  • On the customization example, maybe use dummy example for the logo and icon URLs: I put dummies now.

If you have time, you can review again those items. Thanks!

@jgfrancisco
Copy link
Author

Hi @haroldcalayan,

Customizations still show:

customization.iconUrl = "https://cdn.paymaya.com/production/checkout_api/customization_example/youricon.ico";
customization.appleTouchIconUrl = "https://cdn.paymaya.com/production/checkout_api/customization_example/youricon_ios.ico";
customization.customTitle = "Checkout Page Title";
customization.colorScheme = "#368d5c";

maybe align with other examples and use cdn.someserver.com instead

barayantan pushed a commit that referenced this issue Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants