Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any standardized rule for class names #209

Open
dinukadesilva opened this issue May 29, 2017 · 2 comments
Open

Any standardized rule for class names #209

dinukadesilva opened this issue May 29, 2017 · 2 comments

Comments

@dinukadesilva
Copy link
Contributor

For an example

pe-btn__primary--btn_xlarge

This has dashes, underscores, double dashes, double underscores. I assume this is a bit difficult even to understand. How about following a simple format like this unless there are any technical limitations. (As same as bootstrap)

pe-btn pe-btn-primary pe-btn-xlarge

Regards,
@dinukadesilva
@wyseguyonline
Copy link
Contributor

We are considering this for the next round of refactoring to go into Elements.

@StommePoes
Copy link
Contributor

https://github.com/Pearson-Higher-Ed/elements-sdk/pull/5/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StommePoes @dinukadesilva @wyseguyonline