Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test XRootD logging has become too verbose #2018

Closed
jhiemstrawisc opened this issue Feb 14, 2025 · 0 comments · Fixed by #2019
Closed

Unit test XRootD logging has become too verbose #2018

jhiemstrawisc opened this issue Feb 14, 2025 · 0 comments · Fixed by #2019
Assignees
Labels
internal Internal code improvements, not user-facing test Improvements to the test suite

Comments

@jhiemstrawisc
Copy link
Member

I still think PR #1988, where XRootD log levels were tied to the Logging.Level param, was the right thing to do. However, this means that all our unit tests that spin up a fed-in-a-box are now cranking up XRootD logs, which has resulted in seriously verbose output in GHA -- to the point that it makes you download failed action logs instead of displaying them.

I think the fix should be fairly simple -- pin XRootD log levels to their "error"-level defaults in the fed test instantiation.

@jhiemstrawisc jhiemstrawisc added internal Internal code improvements, not user-facing test Improvements to the test suite labels Feb 14, 2025
@jhiemstrawisc jhiemstrawisc self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal code improvements, not user-facing test Improvements to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant