Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --anat-space-definition to --subject-anatomical-reference #847

Closed
tsalo opened this issue Nov 7, 2024 · 0 comments · Fixed by #855
Closed

Rename --anat-space-definition to --subject-anatomical-reference #847

tsalo opened this issue Nov 7, 2024 · 0 comments · Fixed by #855
Labels
breaking-change Issues/PRs that change results or interfaces. enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Nov 7, 2024

Summary

This would better match the proposal for sMRIPrep and fMRIPrep in nipreps/smriprep#429.

Also, each of the options could be renamed to match sMRIPrep's proposal:

  • session --> sessionwise
  • first --> first-alphabetically to be clear how sessions are sorted
  • robust-template --> unbiased

longitudinal would be reserved for the Freesurfer longitudinal pipeline, if anyone ever wants to implement that.
@tsalo tsalo added enhancement New feature or request breaking-change Issues/PRs that change results or interfaces. labels Nov 7, 2024
@tsalo tsalo mentioned this issue Nov 8, 2024
Merged
@tsalo tsalo closed this as completed in #855 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Issues/PRs that change results or interfaces. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename --anat-space-definition to --subject-anatomical-reference PennLINC/qsiprep
1 participant
@tsalo