Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI tests using xcp_d.cli.run.main() do not contribute to coverage #1154

Open
tsalo opened this issue Apr 24, 2024 · 1 comment
Open

CLI tests using xcp_d.cli.run.main() do not contribute to coverage #1154

tsalo opened this issue Apr 24, 2024 · 1 comment
Labels
bug Issues noting problems and PRs fixing those problems. testing Improving testing in the project.

Comments

@tsalo
Copy link
Member

tsalo commented Apr 24, 2024

Summary

In #1152, I've started using xcp_d.cli.run.main() to run the XCP-D workflow in tests, but for some reason, even though the tests run successfully, CodeCov doesn't detect that they've run the actual workflows, interfaces, etc. I'm not sure why that is, but it would be great to fix it, since switching over would drop the package's coverage from 83.21% to 66.66%.

In the meantime, I've kept the old way of running the tests and have only switched to the cleaner way for one of the integration tests. I'd very much like to move completely to the cleaner way in the future.

@tsalo tsalo added bug Issues noting problems and PRs fixing those problems. testing Improving testing in the project. labels Apr 24, 2024
@tsalo
Copy link
Member Author

tsalo commented Sep 28, 2024

Also using the MultiProc nipype config means non-main tests don't contribute to coverage either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems. testing Improving testing in the project.
Projects
None yet
Development

No branches or pull requests

1 participant