Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support session-wise post-processing #1306

Open
tsalo opened this issue Oct 28, 2024 · 8 comments
Open

Support session-wise post-processing #1306

tsalo opened this issue Oct 28, 2024 · 8 comments
Labels
enhancement New feature or request
Milestone

Comments

@tsalo
Copy link
Member

tsalo commented Oct 28, 2024

Summary

Anatomical processing is done across sessions. Power users work around this by using the --bids-filter-file to run each session separately, but we should natively support session-wise processing.

@cindyhfls
Copy link

The link to the example JSON file for this flag is broken. Can you fix that? https://xcp-d.readthedocs.io/en/latest/usage.html. What should be the argument used to run each session separately

@tsalo
Copy link
Member Author

tsalo commented Nov 13, 2024

I've opened #1323 to fix the link.

I don't think we'll have an argument on XCP-D's end to enably session-wise processing. It should depend on the organization of the input data.

@cindyhfls
Copy link

cindyhfls commented Nov 13, 2024

Thanks.

So if I do:

{
   "bold": {
      "session": ["01","02"],
      "task": ["rest"]
   }
}

It would try to use the same anatomical file, but if I do:

{
   "bold": {
      "session": ["01"],
      "task": ["rest"]
   }
}

and run the pipeline again on

{
   "bold": {
      "session": ["02"],
      "task": ["rest"]
   }
}

Then it's okay?

@tsalo
Copy link
Member Author

tsalo commented Nov 13, 2024

You should probably include "session": ["01"] for all of the entries in https://github.com/PennLINC/xcp_d/blob/7694faa6fcbe0f5ed3d9ab0bf272f7ecedaf5a0d/xcp_d/data/io_spec.yaml.

@cindyhfls
Copy link

I don't quite follow that, can you provide a toy example of how this --bids-filter-file is used?

@tsalo
Copy link
Member Author

tsalo commented Nov 13, 2024

Something like this

{
    "anat_brainmask": {
        "session": "01"
    },
    "anat_to_template_xfm": {
        "session": "01"
    },
    "bold": {
        "session": "01"
    },
    "cortical_thickness": {
        "session": "01"
    },
    "cortical_thickness_corr": {
        "session": "01"
    },
    "lh_pial_surf": {
        "session": "01"
    },
    "lh_subject_sphere": {
        "session": "01"
    },
    "lh_wm_surf": {
        "session": "01"
    },
    "myelin": {
        "session": "01"
    },
    "myelin_smoothed": {
        "session": "01"
    },
    "rh_pial_surf": {
        "session": "01"
    },
    "rh_subject_sphere": {
        "session": "01"
    },
    "rh_wm_surf": {
        "session": "01"
    },
    "sulcal_curv": {
        "session": "01"
    },
    "sulcal_depth": {
        "session": "01"
    },
    "t1w": {
        "session": "01"
    },
    "t2w": {
        "session": "01"
    },
    "template_to_anat_xfm": {
        "session": "01"
    }
}

@tsalo tsalo removed their assignment Nov 22, 2024
@mattcieslak
Copy link
Contributor

@tsalo wdyt about adding --session-id for session filtering?

@tsalo
Copy link
Member Author

tsalo commented Nov 22, 2024

That should definitely be part of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants