Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default implementation for preprocess_transforms and setup_execution_config #6632

Open
wants to merge 168 commits into
base: master
Choose a base branch
from

Conversation

astralcai
Copy link
Contributor

@astralcai astralcai commented Nov 25, 2024

Context:
As a follow up to #6433, implement a default preprocessing transform for devices that implements a capabilities data class.

Description of the Change:
Adds a default implementation of preprocess_transforms and setup_execution_config

Benefits:
Makes it easier for device developers

Related GitHub Issues:
[sc-71719]
[sc-78760]

Base automatically changed from split-preprocess to master November 27, 2024 19:03
@astralcai astralcai marked this pull request as ready for review November 27, 2024 22:02
@astralcai astralcai changed the title [WIP] Default implementation for preprocess_transforms and setup_execution_config Default implementation for preprocess_transforms and setup_execution_config Nov 27, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (ecc8fec) to head (1894f48).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6632   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         455      455           
  Lines       42936    42998   +62     
=======================================
+ Hits        42787    42849   +62     
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai
Copy link
Contributor Author

It just occurred to me, should I add diagonalize_measurements to the program?

@astralcai
Copy link
Contributor Author

astralcai commented Nov 28, 2024

The issue is that diagonalize_measurements assumes that split_non_commuting has already been applied (wouldn't make sense otherwise), but what if the device supports non-commuting observables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant