Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/icons new #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gregory-K
Copy link

new add-on icon (logo?) and url bar icons (v.1.0)

@Gregory-K
Copy link
Author

Gregory-K commented Nov 17, 2017

Made this PR mostly to talk about the PR here and not in "issues".
(I am used to private git collaboration where everything can reset, I now see that GitHub, and for a good reason, doen't allow resets and everything is history).

Well, check the URL-bar icon, I made an addition of an up-arrow. If you don't like it, we can revert it to a simple folder or a simple arrow.
arrow-10-01
arrow-04-01 funky
arrow-05-01 this is like Firefox gives the functionality to "go up" (good)
arrow-06-01 good but it's like the pocket icon reversed
arrow-08-01 discreet good
arrow-09-01

As for the add-on icon. If you like it, I have to update the 96.png without the "fold up" text. If you don't, I don't know if it is possible to just merge the first commit only.
In any case I can delete the branch and create a new one.

@PerfectSlayer
Copy link
Owner

PerfectSlayer commented Nov 21, 2017

Hey, nice icons! 👍
I especially like the ones into a circle:
icon1 Makes me think about an udate/upgrade. Am I the only one?
icon2 I don't care it looks like a reversed Pocket icon. It just proof the icon is coherent with the others.

The add-on icon looks good too but I still don't know if we will call it "Fold up!" 😅

P.S.: Sorry for the delay, I'm quite busy those days…

@Gregory-K
Copy link
Author

Gregory-K commented Nov 23, 2017

Hello,

I am attached to that damned folder+up icon :) because it was the first and the most difficult one.
Nevertheless, I like also the up in circle (the one that reminds you of an update :)).
I like the icon to be a natural continuance of the existing navigational icons Firefox is providing.
I would very much like the idea of an option to drag that icon next to the other navigational icons (top left, outside url bar).

One problem I thought of is the different icon-set on Firefox Developer. They aren't circled. I don't know if that is the future or just an on-purpose choice only for Firefox Developer. (but that can be updated accordingly).
edit On second inspection I thing Mozilla is leading to non-circled icons (Firefox stable has only the "back" arrow into circle").


As for the add-on icon (or ... logo) I think it is good enough (better than many out there) and as soon we clarify the name, it can be on or nowhere to be seen.

@PerfectSlayer
Copy link
Owner

I would very much like the idea of an option to drag that icon next to the other navigational icons (top left, outside url bar).

In fact, you are the second one to ask for this feature! Some leave a note about it in the reviews. I'm still thinking about it because it will be difficult to provide both icons.

I mean, if I offer a browser action button, it will be added and shown by default. So I will have to disable the current page action button for the current users. And for the user who like it, they should customize browser actions to remove the new icon and go to the settings to add the page action button again. Weird, isn't it?

I am on the stable version and no circle here! But I agree the SUF button should be nice with them 😉
image

@Gregory-K
Copy link
Author

I just read this stack exchange and for a moment I had a funny feeling.
2017-11-23_140023
here is also into circle https://www.mozilla.org/en-US/firefox/

@Gregory-K
Copy link
Author

Gregory-K commented Nov 23, 2017

I am new in this field of firefox add-ons.
How difficult (or even doable) is to add an once upon install/update check for the previous settings (or version) and maintain the url icon?
I mean... Firefox put the "refresh" icon there for years, repositioned it into the url field for years and now is back on the left again.
For me, it is more convenient also to "customize" the position of an icon than having to disable/enable them from settings pages. If someone wants it right after the url, he can drag it there (my first thought about "refresh" due to muscle memory).

@PerfectSlayer
Copy link
Owner

Hi @Gregory-K !
Sorry to leave the PR here 😓
Could you just remove the "Fold Up" words in the icon so I could merge it?
(I am not ready to change the name but I really like to have your icon right now 😍 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants