Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRBv3 stake changes not submitted to chain #1376

Open
Nexus2k opened this issue Sep 2, 2023 · 3 comments
Open

PRBv3 stake changes not submitted to chain #1376

Nexus2k opened this issue Sep 2, 2023 · 3 comments

Comments

@Nexus2k
Copy link

Nexus2k commented Sep 2, 2023

I have a running PRBv3 setup on Khala. When I adjust the stake of a worker I expect PRBv3 to adjust the stake after a restart of the WM service. However it doesn't seem to care about the actual stake of the worker.

I update the stake thru a direct API call from a python script (which basically just modifies the stake value) and then restart WM from the Monitor UI.

Steps to reproduce:

  1. Setup PRBv3
  2. setup a worker with stake at 1000 PHA
  3. have it working on-chain
  4. change stake to 2000 PHA
  5. restart PRBv3 (aka WM)

Expected outcome:
Stake should be checked on-chain vs. configured and stake update request should be sent.

Actual outcome:
You will see stake never get's updated.

@Nexus2k
Copy link
Author

Nexus2k commented Sep 8, 2023

I believe https://github.com/search?q=repo%3APhala-Network%2Fphala-blockchain%20path%3A%2F%5Estandalone%5C%2Fprb%5C%2F%2F%20stake&type=code is missing some code to check the on-chain stake vs. the configured stake, because stake updates need a RESTART_COMPUTING call.

@Nexus2k
Copy link
Author

Nexus2k commented Sep 8, 2023

@Nexus2k
Copy link
Author

Nexus2k commented Sep 18, 2023

I've added this feature now in my version of the WM, but won't contribute because the devs have no respect for other pressing issues like #1285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant