-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe annotations? #80
Comments
Hi Katie!!! Sorry I never got around to responding to this. This is an awesome feature, so thank you so much for getting it started. When I get the chance I would definitely like to incorporate this as a new feature (maybe as its own annotation function? that way it's not as confusing with |
Hi Nicole!! :) No problem at all! To be honest I'm not doing a ton with stripes so the little custom function has worked a-okay for me so far - it was more of a curiosity than a super required/deal-breaking feature for me haha. In general they seem to be a more niche area still (although I guess that could change with more Micro-C, but I still feel like TADs and loops will be king). That said, if you do make an official pg function for it'd I'd definitely be a user! Btw I agree that having a separate function makes perfect sense so that the |
Hello! Thanks for the great tool. And thanks @ksmetz for generating these new functions. I am also trying to generate plots in plot gardener regarding stripes and I am having a hard time figuring out how to do so. Has any more progress been made on this front? |
Hi Nicole + plotgardener team! :)
I am trying to annotate stripes on a Hi-C map using rectangles. Since there didn't seem to be an existing function for this (
annoPixels
doesn't parse/plot the stripe coordinates quite right), I wrote my own little function that accomplished this using thegrid.polygon
function.It requires a GInteractions object of stripe coordinates (
stripeGI
, i.e. read in from Stripenn results), the name of the viewport containing the pg plot to be annotated (pgPlot
, i.e."hicSquare1"
), and a chr/start/stop position of the window you are plotting for. See here:This is very basic and I'm working on adjusting it still, but the basic concept works fine.
However, there are a few downsides to this - for example, adjusting which side of the diagonal it plots on is a little tricky, and I'm not sure how to apply this to a rectangular Hi-C plot (since I'm not sure what the native y coordinates are there). I also worried that I was sort of reinventing the wheel, since it seems so close to other existing plotgardener functions.
I was wondering if it is possible to adapt
annoPixels
to be able to draw boxes with custom coordinates (instead of making a square box), in a way that would make it compatible with stripe calls? Or are there any current plans for a separate function for annotating stripes or similar features?If not, I was wondering if you have any advice on how to improve my current approach, or how to apply something similar to rectangle plots? The current function only works with square plots because of the way it uses x/y coordinates.
Again since I've got a working function this isn't super urgent, more a matter of curiosity!
Thanks for your time and insights!
-Katie
The text was updated successfully, but these errors were encountered: