Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Calculator(verbose=False) should not print (or tqdm) any output #18

Open
bocklund opened this issue Aug 13, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request QoL quality of life

Comments

@bocklund
Copy link
Member

The verbose output is helpful to see what's going on and get realtime feedback, but sometimes it's hard to find my output among all of pysipfenn's output. I'd like to be able to hide all the output (at least on the happy path, if stuff is breaking or not right, then being noisy is the right thing to do IMO).

@amkrajewski
Copy link
Contributor

Thanks for the feedback @bocklund ! As always, it is very much appreciated!

The idea behind this switch was to make printouts verbose vs. concise rather than on vs. off, but you are right that a no-printout option would be nice to have. I was actually thinking about it like two months ago - whether or not to turn it into a "verbosityLevel" switch with Flase, 0, 1, ... options.

Another option I like, especially in the context of debugging, would be to have both verbose and printout switches, where Calculator with the default printout=True acts just like now, while printout=False will direct messages, verbose or concise, into an internal logger variable that could be accessed when needed. What are your thoughts on that?

@amkrajewski
Copy link
Contributor

amkrajewski commented Aug 23, 2024

I created a new branch, improve_CalculatorPrintout, for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request QoL quality of life
Projects
None yet
Development

No branches or pull requests

2 participants