-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interactive_builder.py Fix or upgrade? #64
Comments
Maybe we should let the user select any version? |
Yes when possible it should provide a version list after selecting from distributions. Or simple selecting cx or proton would just download head and build but selecting from "upstream, staging, dos_support" would then provide the wine version listing |
Why not trusting the other and not listing anything? |
I'm sorry I don't follow what you mean here? |
Our main problem is to find a suitable way to enumerate the versions for a given distribution. This enumeration is not required to trigger a build. You can use a raw input string instead. The drawback is that the user needs to know what version he can build and type it without mistake |
Ah now I get what you mean.
That was my other suggestion only list versions for wine but just get head for proton/winecx that would not be ideal but at least it would work. |
I don’t think winebuild can build head for the moment |
Hum then for now wouldn't it be safer to remove both cx and proton options from interactive_builder.py? it does include an example for cx already a proton one could also be added with easy. |
Not sure, proton and cx properly supports version |
They do not support listing version, this is a bit different |
@qparis that's why I'm saying then would it not be better to just remove these options from interactive_builder.py then? |
I don’t understand how it would help |
I'm suggesting the options be temporally be removed from "interactive_builder.py" until those options can be used without failing. |
They can actually. The only thing we cannot do with these build is enumarating the list of available versions. However, such a list exists. Just, you cannot see it. Appart from that, these distribution work exactly likr upstream and staging |
After the recent change it’s now possible to select proton and cx however this takes place after the listing pulled from wine’s git so selecting those means the build will error before it starts.
Instead wouldn’t it be better to ask before hand what your wanting to build then provide a list of options.
So selecting Proton would show proton versions same for WineCX (if you had others available that is)
Or remove these two options from the menu and add examples for both that scripts that build both of these distributions.I can add examples in my next pull-request,added WineCX examples to #67The text was updated successfully, but these errors were encountered: