Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive_builder.py Fix or upgrade? #64

Open
Gcenx opened this issue Feb 3, 2019 · 14 comments
Open

interactive_builder.py Fix or upgrade? #64

Gcenx opened this issue Feb 3, 2019 · 14 comments

Comments

@Gcenx
Copy link
Contributor

Gcenx commented Feb 3, 2019

After the recent change it’s now possible to select proton and cx however this takes place after the listing pulled from wine’s git so selecting those means the build will error before it starts.

Instead wouldn’t it be better to ask before hand what your wanting to build then provide a list of options.

So selecting Proton would show proton versions same for WineCX (if you had others available that is)

Or remove these two options from the menu and add examples for both that scripts that build both of these distributions.

I can add examples in my next pull-request, added WineCX examples to #67

@qparis
Copy link
Member

qparis commented Feb 10, 2019

Maybe we should let the user select any version?

@Gcenx
Copy link
Contributor Author

Gcenx commented Feb 10, 2019

Maybe we should let the user select any version?

Yes when possible it should provide a version list after selecting from distributions.
But that depends on how many versions of WineCX you want to have available later, plus how would Proton be handled since each version head is in a different branch?

Or simple selecting cx or proton would just download head and build but selecting from "upstream, staging, dos_support" would then provide the wine version listing

@qparis
Copy link
Member

qparis commented Feb 10, 2019

Why not trusting the other and not listing anything?

@Gcenx
Copy link
Contributor Author

Gcenx commented Feb 10, 2019

Why not trusting the other and not listing anything?

I'm sorry I don't follow what you mean here?

@qparis
Copy link
Member

qparis commented Feb 10, 2019

Our main problem is to find a suitable way to enumerate the versions for a given distribution. This enumeration is not required to trigger a build. You can use a raw input string instead. The drawback is that the user needs to know what version he can build and type it without mistake

@Gcenx
Copy link
Contributor Author

Gcenx commented Feb 10, 2019

Our main problem is to find a suitable way to enumerate the versions for a given distribution. This enumeration is not required to trigger a build. You can use a raw input string instead. The drawback is that the user needs to know what version he can build and type it without mistake

Ah now I get what you mean.

Why not trusting the other and not listing anything?

That was my other suggestion only list versions for wine but just get head for proton/winecx that would not be ideal but at least it would work.

@qparis
Copy link
Member

qparis commented Feb 10, 2019

I don’t think winebuild can build head for the moment

@Gcenx
Copy link
Contributor Author

Gcenx commented Feb 10, 2019

I don’t think winebuild can build head for the moment

Hum then for now wouldn't it be safer to remove both cx and proton options from interactive_builder.py? it does include an example for cx already a proton one could also be added with easy.

@qparis
Copy link
Member

qparis commented Feb 10, 2019

Not sure, proton and cx properly supports version

@qparis
Copy link
Member

qparis commented Feb 10, 2019

They do not support listing version, this is a bit different

@Gcenx
Copy link
Contributor Author

Gcenx commented Feb 11, 2019

@qparis that's why I'm saying then would it not be better to just remove these options from interactive_builder.py then?

@qparis
Copy link
Member

qparis commented Feb 11, 2019

I don’t understand how it would help

@Gcenx
Copy link
Contributor Author

Gcenx commented Feb 11, 2019

I don’t understand how it would help

I'm suggesting the options be temporally be removed from "interactive_builder.py" until those options can be used without failing.

@qparis
Copy link
Member

qparis commented Feb 11, 2019

They can actually. The only thing we cannot do with these build is enumarating the list of available versions. However, such a list exists. Just, you cannot see it. Appart from that, these distribution work exactly likr upstream and staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants