Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool: removes the hardcoded value for tolerance and adds it as parameter to split_deposit_based_on_pool_ratio #257

Closed
wants to merge 10 commits into from
Closed

Pool: removes the hardcoded value for tolerance and adds it as parameter to split_deposit_based_on_pool_ratio #257

wants to merge 10 commits into from

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Feb 27, 2024

No description provided.

@gangov
multihop, pool: removes the hardcoded value for tolerance and adds it…
c9fae9c 
… as parameter to split_deposit_based_on_pool_ratio
@gangov gangov self-assigned this Feb 27, 2024
@gangov gangov linked an issue Feb 27, 2024 that may be closed by this pull request
[V-PHX-VUL-031] Static tolerance value may lead to high imprecision for small pools #226
Open
@gangov gangov requested a review from ueco-jb February 27, 2024 20:32
ueco-jb
ueco-jb reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress.

contracts/pool/src/contract.rs Outdated Show resolved Hide resolved
contracts/pool/src/storage.rs Outdated Show resolved Hide resolved
@gangov gangov requested a review from ueco-jb February 28, 2024 19:27
ueco-jb
ueco-jb reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually now I don't see why we renamed it to a _bps - it doesn't make sense, that difference is not in a percentage.
Please rename it back. I will consider if we still need that value.

@gangov gangov requested a review from ueco-jb March 6, 2024 15:44
ueco-jb
ueco-jb reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm putting this on pause, I need to take another look on this tolerance logic.

contracts/pool/src/contract.rs Outdated Show resolved Hide resolved
contracts/pool/src/storage.rs Outdated Show resolved Hide resolved
contracts/pool/src/tests/liquidity.rs Outdated Show resolved Hide resolved
@ueco-jb ueco-jb mentioned this pull request Apr 29, 2024
Open
@ueco-jb
Copy link
Member

ueco-jb commented Apr 30, 2024

No longer valid.

@ueco-jb ueco-jb closed this Apr 30, 2024
@ueco-jb ueco-jb deleted the 226-v-phx-vul-031-static-tolerance-value-may-lead-to-high-imprecision-for-small-pools branch April 30, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb left review comments

Assignees

@gangov gangov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[V-PHX-VUL-031] Static tolerance value may lead to high imprecision for small pools
2 participants
@gangov @ueco-jb