Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin depending player ignoring support #4

Open
Phoenix616 opened this issue May 14, 2016 · 5 comments
Open

Plugin depending player ignoring support #4

Phoenix616 opened this issue May 14, 2016 · 5 comments

Comments

@Phoenix616
Copy link
Owner

Don't count AFK players. For example by hooking into Essentials or maybe even running our own AFK checks (although I don't really want to get into this, might be only something for future updates if it really is needed)

@Phoenix616 Phoenix616 added this to the 1.0 rewrite milestone May 14, 2016
@MattSturgeon
Copy link
Contributor

FYI I'm working on a simple plugin that sets the betterbeds.ignore permission to true while WhosAFK set's a player afk

@Phoenix616
Copy link
Owner Author

You could also just fork and implement it directly into the plugin ;)

@MattSturgeon
Copy link
Contributor

MattSturgeon commented Sep 7, 2016

You could also just fork and implement it directly into the plugin ;)

Yes, however if you look at my approach you'll see it makes more sense as a seperate plugin for a few reasons; most importantly, the code is specific to two plugins, you may decide there are better alternatives to WhosAFK, or someone using WhosAFK may wish to use an alternative bed plugin.

Also this is the first time I've used Java or the Bukkit API, so it made more sense for me to work on something small and independant.

EDIT: Thought about the WhosAFK from a different approach, and I have come up with a simpler method than my integration plugin in PR #6

@Phoenix616
Copy link
Owner Author

Phoenix616 commented Sep 30, 2019

Some more thoughts about this issue:

It should generally support ignoring people due to multiple different parameters, the most obvious ones being the player being afk or the player being vanished. For that each supported plugin should use a different maven module and the different ignore types be configurable in the config.

AFK status as well as vanishing would ideally be handled by a ServiceProvider similarly to how Vault provides a unified interface, maybe something to integrate into Tresor?

@Phoenix616 Phoenix616 changed the title AFK player support Plugin depending player ignoring support Sep 30, 2019
@seema84
Copy link

seema84 commented Feb 23, 2021

has it been implemented since 2016 in the meantime (for example essentialsx)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants