Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow upload compared with the old sender #16

Open
X3msnake opened this issue Sep 11, 2019 · 5 comments
Open

Slow upload compared with the old sender #16

X3msnake opened this issue Sep 11, 2019 · 5 comments

Comments

@X3msnake
Copy link
Member

So for some reason uploading the 19MB file with the latest release takes ages, while uploading with the old sender takes about 2 minutes

Another thing i found is that the new version does not show the rest of the files on the USB.

I believe you made it intentional? but it should at least have the possibility to run all runnable photon files, likr the Update.bin, .LCD and .Gcode

image

image

@lagnajeet
Copy link
Collaborator

I tested the issue. It's not a bug. Disable logging and the file upload is 5 times faster than with logging enabled. The logging function is only there to catch errors. there is no need to have it enabled if not needed.

image

@lagnajeet
Copy link
Collaborator

For listing of files, i didn't put a check for .photon files but I did put a check that won't show files that are reported to be of size zero. I can disable that check and it will show all files.

@X3msnake
Copy link
Member Author

X3msnake commented Sep 21, 2019 via email

@ruralaccent
Copy link

Are you able to add show all files as an option in settings? Also, is it possible to show folders, not just files, so we can order and arrange files, rather than just have one long list?

@bgyarfas
Copy link

bgyarfas commented Nov 3, 2021

I tested the issue. It's not a bug. Disable logging and the file upload is 5 times faster than with logging enabled. The logging function is only there to catch errors. there is no need to have it enabled if not needed.

This is the solution, you'll also see all the other operations speed up as well. For some reason the call to saveLog opens and closes the log file on every call! Adds about 100ms of latency for every packet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants