Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the AppData file removal #198

Open
AsciiWolf opened this issue Oct 31, 2023 · 1 comment
Open

Revert the AppData file removal #198

AsciiWolf opened this issue Oct 31, 2023 · 1 comment

Comments

@AsciiWolf
Copy link

Please, consider reverting this commit. AppStream metadata are a standard thing required by many distributions/package managers nowadays. Removing them makes no sense.

@AsciiWolf
Copy link
Author

By the way, it looks like that the appdata file had a problem that prevented it to work with most AppStream parsers (except flatpak-builder) because they could not match the desktop file name. It should have contained this line:

<launchable type="desktop-id">pingus.desktop</launchable>

So, if the appdata file removal commit gets reverted, please also modify the file and add this line. Preferably also rename the appdata file from "pingus.appdata.xml.in" to "org.seul.pingus.Pingus.appdata.xml.in".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant