-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete refresh #49
Complete refresh #49
Conversation
Allow call to get ID of public room (channel) or user
Although the call of |
Add .invite functions and create private room
Hey @pipozzz can you have a look? Closed most of your open issues and made a few enhancements. |
I'm a little busy right now, but definitely I'll review it and let you know. Thanks for contribution. |
Co-authored-by: Peter Gonda <[email protected]>
AUTHORS.txt
Outdated
@@ -1,3 +1,4 @@ | |||
Derek Stegelman - dstegelman | |||
Jorge Alberto Díaz Orozco - jadolg | |||
cesarandreslopez | |||
Luca Zimmermann - soundstorm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, do not touch AUTHORS.txt, I'm planning to create CONTRIBUTORS.txt file which better describe its purpose.
Also we need to resolve failed build before merging, btw Thanks for your contribution again ! 👍 |
Co-authored-by: Peter Gonda <[email protected]>
Hello, @soundstorm!
I'm very new to programming, but interested in the project, thank you! |
It seems that code is OK just test coverage dropped below 85%. |
This is still in the refresh branch after two years, will there be a release with those changes anytime? |
Hi @soundstorm, I was very busy, but Yes I'll review it and merge it if it's fine. There was failed some test last time I took a look. So let me check it again and merge it if it's fine. Thanks |
Allow call to get ID of public room (channel) or user; bump to 1.2.15
Will allow better code for fraschetti/Octoslack#93
Closes #46 as getting the id is now possible (but still not without auth).
Allow to create private rooms, invite users to rooms/channels (closes #35)
Complete documentation in README (closes #38 and closes #48)