From 330777b0dbe226b4bf81f9c460a3260b434ef78f Mon Sep 17 00:00:00 2001
From: Istvan Szekeres <szekeres@iii.hu>
Date: Mon, 16 Dec 2024 22:44:49 +0000
Subject: [PATCH] Fix encoding of inline content

Inline content with the file containing e.g. a `:` cannot be displayed
as the file name is set as the img src, and the browser treats the part
before the : as the protocol, instead of as a file name.

This change encodes the file name so `:` becomes `%3A`, fixing the
issue.

Fixes #1182.
---
 web/cm_plugins/inline_content.ts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/web/cm_plugins/inline_content.ts b/web/cm_plugins/inline_content.ts
index b5e2bbc3..52b4856f 100644
--- a/web/cm_plugins/inline_content.ts
+++ b/web/cm_plugins/inline_content.ts
@@ -56,15 +56,17 @@ class InlineContentWidget extends WidgetType {
       return div;
     }
 
+    const url = encodeURIComponent(this.url)
+
     if (mimeType.startsWith("image/")) {
       const img = document.createElement("img");
-      img.src = this.url;
+      img.src = url;
       img.alt = this.title;
       this.setDim(img, "load");
       div.appendChild(img);
     } else if (mimeType.startsWith("video/")) {
       const video = document.createElement("video");
-      video.src = this.url;
+      video.src = url;
       video.title = this.title;
       video.controls = true;
       video.autoplay = false;
@@ -72,7 +74,7 @@ class InlineContentWidget extends WidgetType {
       div.appendChild(video);
     } else if (mimeType.startsWith("audio/")) {
       const audio = document.createElement("audio");
-      audio.src = this.url;
+      audio.src = url;
       audio.title = this.title;
       audio.controls = true;
       audio.autoplay = false;
@@ -81,7 +83,7 @@ class InlineContentWidget extends WidgetType {
     } else if (mimeType === "application/pdf") {
       const embed = document.createElement("object");
       embed.type = mimeType;
-      embed.data = this.url;
+      embed.data = url;
       embed.style.width = "100%";
       embed.style.height = "20em";
       this.setDim(embed, "load");