feat: Kramer switches PPT-367 #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkheav
requested review from
a team and
websymphony
and removed request for
a team and
websymphony
Open
stakach
requested changes
Feb 23, 2021
There was a problem hiding this comment.
These drivers should implement the Switchable interface
@kimburgess we should probably update your Extron Matrix driver to do the same
The switchable interface was brainstormed early on, so happy for updates to made to the interface too.
On line 2, I added the 'require' statement to 'include' the switchable interface on line 55.
|
@stakach can you please review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ported 2/3 drivers from here but not here as it is just a simple extension of the driver p3000 driver.
I can port the presentation.rb driver if needed though as it is simple.
Closes #47