Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter filter_genes_by_aa_length #127

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Dec 10, 2024

PR checklist

  • Added parameter filter_genes_by_aa_length
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Dec 10, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ab3ae37

+| ✅ 104 tests passed       |+
#| ❔  18 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: assets/nf-core-genepal_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genepal_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genepal_logo_dark.png
  • nextflow_config - nextflow_config
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File does not exist: assets/nf-core-genepal_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genepal_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genepal_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/genepal/genepal/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-11 20:59:41

@GallVp GallVp added this to the 0.6.0 milestone Dec 10, 2024
@GallVp
Copy link
Member Author

GallVp commented Dec 10, 2024

Hi @rosscrowhurst

Can you kindly do,

git fetch upstream
git fetch origin

git checkout feat/filter_genes_by_aa_length

./pfr_genepal

to resume your previous run with the updated code and check if you get the desired effects from the filter_genes_by_aa_length parameter?

Please don't mid going through the PR code changes and highlight anything that sticks out. Many Thanks!

@GallVp GallVp marked this pull request as draft December 11, 2024 03:49
@@ -240,6 +240,10 @@ process { // SUBWORKFLOW: GFF_MERGE_CLEANUP
ext.prefix = { "${meta.id}.liftoff.braker" }
}

withName: '.*:GFF_MERGE_CLEANUP:FILTER_BY_ORF_SIZE' {
ext.args = params.filter_genes_by_aa_length ? "--no-pseudo --keep-genes -C -l ${params.filter_genes_by_aa_length * 3}" : ''
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rosscrowhurst

params.filter_genes_by_aa_length is multiplied by 3 to get the CDS length for the -l parameter.

@GallVp
Copy link
Member Author

GallVp commented Dec 11, 2024

Hey @rosscrowhurst

Here is another attempt at solving the same problem. Please update your clone once again and try another resume. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final annotation protein sequence length includes exceedingly short proteins
1 participant