-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added parameter filter_genes_by_aa_length #127
base: dev
Are you sure you want to change the base?
Conversation
|
Can you kindly do, git fetch upstream
git fetch origin
git checkout feat/filter_genes_by_aa_length
./pfr_genepal to resume your previous run with the updated code and check if you get the desired effects from the Please don't mid going through the PR code changes and highlight anything that sticks out. Many Thanks! |
@@ -240,6 +240,10 @@ process { // SUBWORKFLOW: GFF_MERGE_CLEANUP | |||
ext.prefix = { "${meta.id}.liftoff.braker" } | |||
} | |||
|
|||
withName: '.*:GFF_MERGE_CLEANUP:FILTER_BY_ORF_SIZE' { | |||
ext.args = params.filter_genes_by_aa_length ? "--no-pseudo --keep-genes -C -l ${params.filter_genes_by_aa_length * 3}" : '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
params.filter_genes_by_aa_length is multiplied by 3 to get the CDS length for the -l
parameter.
Hey @rosscrowhurst Here is another attempt at solving the same problem. Please update your clone once again and try another resume. Many thanks! |
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).