Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrolling issues on list/details pages #2310

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix scrolling issues on list/details pages #2310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 19 additions & 27 deletions src/features/common/Layout/ProjectsLayout/ProjectsLayout.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
$layoutPaddingTop: 24px;
$layoutPaddingSide: 20px;
$layoutPaddingBottom: 30px;
$topMobileNavigationSpace: 77px;
$bottomMobileFooterSpace: 49px;

.impersonationMode,
.embedMode,
.projectsLayout {
Expand Down Expand Up @@ -55,42 +58,31 @@ $layoutPaddingBottom: 30px;
}

// styles for mobile layout

.mobileProjectsLayout {
width: 100%;
height: calc(100vh - 58px);
position: relative;
position: fixed;
top: $topMobileNavigationSpace;
left: 0;
right: 0;
bottom: $bottomMobileFooterSpace;
display: flex;
justify-content: center;
margin-top: 58px;
padding-top: $layoutPaddingTop;
flex-direction: column;
overflow: hidden;
&.mapMode {
height: 100vh;
margin-top: 0px;
padding-top: 0px;
}
}
background: white;
padding-top: 24px;

.viewButton {
position: absolute;
top: 13px;
right: 20px;
z-index: 1;
&.viewButtonShifted {
top: 95px;
&.mapMode {
top: 0;
padding-top: 0;
}
}

.mobileContentContainer {
padding: 0px 12px;
height: 100%;
flex: 1;
position: relative;
width: 100%;
margin-top: 20px;
@include xsPhoneView {
padding: 0px;
margin-top: 20px;
}
overflow: hidden;
-webkit-overflow-scrolling: touch;
overscroll-behavior: auto;
}

.mobileMapContainer {
Expand Down
3 changes: 2 additions & 1 deletion src/features/projectsV2/ProjectDetails/ProjectDetails.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
display: none;
}
padding-right: 0px;
padding-bottom: 100px;
padding-bottom: 20px;
height: 100%;
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/features/projectsV2/ProjectDetails/styles/ProjectInfo.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
@include xsPhoneView {
box-shadow: none;
margin-left: 0px;
padding: 15px 30px;
padding: 15px 24px 0;
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/features/projectsV2/ProjectsMap/ProjectsMap.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
.projectListControlsContainer {
position: absolute;
width: 100%;
top: 102px;
top: 101px;
z-index: 2;
}

Expand All @@ -12,7 +12,7 @@
position: absolute;
align-items: center;
gap: 34px;
top: 114px;
top: 101px;
right: 10px;
z-index: 2px;

Expand Down
6 changes: 5 additions & 1 deletion src/features/projectsV2/ProjectsSection.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
@import '../../theme/theme';

$bottomFooterSpace: 49px;

// temporary file will be deleted later
.projectList {
display: flex;
Expand All @@ -21,7 +24,8 @@
&::-webkit-scrollbar {
display: none;
}
padding: 0px 9px 100px;
height: calc(100% - $bottomFooterSpace);
padding: 0px 9px 20px;
}
}

Expand Down
Loading