Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external_field argument to QuadraticFlux and other normal field objectives #1164

Open
dpanici opened this issue Aug 6, 2024 · 1 comment · May be fixed by #1205
Open

Add external_field argument to QuadraticFlux and other normal field objectives #1164

dpanici opened this issue Aug 6, 2024 · 1 comment · May be fixed by #1205
Assignees
@kianorr
Labels
coil stuff relating to coils and coil optimization enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc P3 Highest Priority, someone is/should be actively working on this

Comments

@dpanici
Copy link
Collaborator

dpanici commented Aug 6, 2024

If I want to say optimize a modular coilset in the presence of a background ToroidalField, currently we would have to do so with a SumMagneticField object, passing in the coils and the TF. however, our coil objectives cannot handle a SumMagneticField object so we would be unable to penalize coil coil distance or curvature or anything like that.

If we add in a external_field argument to these objectives that can take in a static external field, we would avoid these issues.

A longer term fix would be to get the coil objectives to work with objects where the field is not given solely by coilsets.
@dpanici
Copy link
Collaborator Author

dpanici commented Aug 13, 2024

Modify pytree function in coil objectives to only use the coilsets in the passed-in magnetic field object

@dpanici dpanici added enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc coil stuff relating to coils and coil optimization labels Aug 13, 2024
@dpanici dpanici mentioned this issue Aug 13, 2024
Open
@ddudt ddudt linked a pull request Aug 19, 2024 that will close this issue
Draft
4 tasks
@dpanici dpanici added the P3 Highest Priority, someone is/should be actively working on this label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kianorr kianorr

Labels
coil stuff relating to coils and coil optimization enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc P3 Highest Priority, someone is/should be actively working on this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow QuadraticFlux etc. to take multiple MagneticField objects PlasmaControl/DESC
2 participants
@dpanici @kianorr