Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should OmnigenousField disallow certain helicity types? #1390

Open
dpanici opened this issue Nov 18, 2024 · 1 comment
Open

Should OmnigenousField disallow certain helicity types? #1390

dpanici opened this issue Nov 18, 2024 · 1 comment
Assignees
@ddudt
Labels
P2 Medium Priority, not urgent but should be on the near-term agend

Comments

@dpanici
Copy link
Collaborator

dpanici commented Nov 18, 2024

DESC/desc/magnetic_fields/_core.py

Line 2404 in 95612fa

# TODO: should we not allow some types of helicity?

@dpanici dpanici added P1 Lowest Priority, will get to eventually P2 Medium Priority, not urgent but should be on the near-term agend and removed P1 Lowest Priority, will get to eventually labels Nov 25, 2024
@dpanici
Copy link
Collaborator Author

dpanici commented Nov 25, 2024

basically, should we throw an error if the field has a certain NFP but a different toroidal helicity (say 1 instead of NFP) is passed in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddudt ddudt

Labels
P2 Medium Priority, not urgent but should be on the near-term agend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddudt @dpanici