Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mirror ratio objective #1366

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add mirror ratio objective #1366

wants to merge 3 commits into from

Conversation

f0uriest
Copy link
Member

Resolves #848

Likely needs #1225 for it to work correctly for OmnigenousField

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.50%. Comparing base (51d637c) to head (e78eaf2).
Report is 50 commits behind head on master.

Files with missing lines Patch % Lines
desc/objectives/_geometry.py 94.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   95.50%   95.50%   -0.01%     
==========================================
  Files          96       96              
  Lines       24028    24065      +37     
==========================================
+ Hits        22948    22983      +35     
- Misses       1080     1082       +2     
Files with missing lines Coverage Δ
desc/compute/_field.py 100.00% <ø> (ø)
desc/objectives/__init__.py 100.00% <ø> (ø)
desc/objectives/_geometry.py 96.79% <94.59%> (-0.23%) ⬇️

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 14, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_midres         |     -3.79 +/- 5.12     | -2.45e-02 +/- 3.30e-02 |  6.20e-01 +/- 2.6e-02  |  6.45e-01 +/- 2.0e-02  |
 test_build_transform_fft_highres        |     -2.14 +/- 3.27     | -2.15e-02 +/- 3.30e-02 |  9.86e-01 +/- 2.5e-02  |  1.01e+00 +/- 2.2e-02  |
 test_equilibrium_init_lowres            |     -5.35 +/- 5.00     | -2.25e-01 +/- 2.10e-01 |  3.98e+00 +/- 2.0e-01  |  4.20e+00 +/- 6.8e-02  |
 test_objective_compile_atf              |     +0.58 +/- 3.82     | +4.61e-02 +/- 3.06e-01 |  8.07e+00 +/- 1.7e-01  |  8.02e+00 +/- 2.6e-01  |
 test_objective_compute_atf              |     -2.34 +/- 5.04     | -2.52e-04 +/- 5.43e-04 |  1.05e-02 +/- 2.6e-04  |  1.08e-02 +/- 4.8e-04  |
 test_objective_jac_atf                  |     +0.95 +/- 2.38     | +1.86e-02 +/- 4.65e-02 |  1.97e+00 +/- 2.8e-02  |  1.95e+00 +/- 3.7e-02  |
 test_perturb_1                          |     -1.02 +/- 3.18     | -1.50e-01 +/- 4.65e-01 |  1.45e+01 +/- 4.3e-01  |  1.47e+01 +/- 1.8e-01  |
 test_proximal_jac_atf                   |     +0.09 +/- 0.93     | +7.11e-03 +/- 7.68e-02 |  8.23e+00 +/- 3.3e-02  |  8.23e+00 +/- 6.9e-02  |
 test_proximal_freeb_compute             |     +0.17 +/- 1.10     | +3.43e-04 +/- 2.18e-03 |  1.99e-01 +/- 1.6e-03  |  1.98e-01 +/- 1.5e-03  |
 test_build_transform_fft_lowres         |     +1.52 +/- 7.46     | +8.00e-03 +/- 3.93e-02 |  5.35e-01 +/- 3.3e-02  |  5.27e-01 +/- 2.1e-02  |
 test_equilibrium_init_medres            |     -0.14 +/- 2.48     | -5.78e-03 +/- 1.03e-01 |  4.14e+00 +/- 6.1e-02  |  4.15e+00 +/- 8.3e-02  |
 test_equilibrium_init_highres           |     +0.33 +/- 1.59     | +1.81e-02 +/- 8.64e-02 |  5.44e+00 +/- 7.1e-02  |  5.43e+00 +/- 4.9e-02  |
 test_objective_compile_dshape_current   |     -0.64 +/- 1.14     | -2.50e-02 +/- 4.44e-02 |  3.86e+00 +/- 4.1e-02  |  3.88e+00 +/- 1.7e-02  |
 test_objective_compute_dshape_current   |     +0.45 +/- 1.70     | +1.62e-05 +/- 6.12e-05 |  3.62e-03 +/- 2.7e-05  |  3.60e-03 +/- 5.5e-05  |
 test_objective_jac_dshape_current       |     -2.78 +/- 7.12     | -1.14e-03 +/- 2.91e-03 |  3.97e-02 +/- 1.2e-03  |  4.09e-02 +/- 2.6e-03  |
 test_perturb_2                          |     -0.51 +/- 1.65     | -9.77e-02 +/- 3.13e-01 |  1.89e+01 +/- 2.3e-01  |  1.90e+01 +/- 2.1e-01  |
 test_proximal_freeb_jac                 |     +0.91 +/- 1.23     | +6.76e-02 +/- 9.14e-02 |  7.51e+00 +/- 7.2e-02  |  7.44e+00 +/- 5.7e-02  |
 test_solve_fixed_iter                   |     +1.28 +/- 60.15    | +6.51e-02 +/- 3.05e+00 |  5.14e+00 +/- 2.2e+00  |  5.07e+00 +/- 2.2e+00  |

@f0uriest f0uriest marked this pull request as draft November 14, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mirror Ratio objective
2 participants