You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
Your logger implementation is really fast! Although we could not achieve the same performance as written in the documentation (maybe because of the difference in platform), it indeed outperform other loggers by far.
Now, I would like to make a small suggestion. I was trying to encapsulate the library inside of a class. Because of NanoLog's heavy dependency on constexpr, it was kind of cumbersome (just little tweaks here and there). To deal with the problem I changed the format string argument type from (&)[N] to std::string_view and it was easier to achieve my goal, without affecting performance.
My suggestion is just that: change (&)[N] to std::string_view.
With that in mind, I don't know if there is a better way of doing this, but using string_views is definitely a solution.
Thanks,
Kevin Baez.
The text was updated successfully, but these errors were encountered:
Hello,
Your logger implementation is really fast! Although we could not achieve the same performance as written in the documentation (maybe because of the difference in platform), it indeed outperform other loggers by far.
Now, I would like to make a small suggestion. I was trying to encapsulate the library inside of a class. Because of NanoLog's heavy dependency on constexpr, it was kind of cumbersome (just little tweaks here and there). To deal with the problem I changed the format string argument type from (&)[N] to std::string_view and it was easier to achieve my goal, without affecting performance.
My suggestion is just that: change (&)[N] to std::string_view.
With that in mind, I don't know if there is a better way of doing this, but using string_views is definitely a solution.
Thanks,
Kevin Baez.
The text was updated successfully, but these errors were encountered: