Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes for proposal picker #125

Merged
merged 5 commits into from
Mar 10, 2022

Conversation

phoebus-84
Copy link

@phoebus-84 phoebus-84 commented Mar 9, 2022

🎩 What? Why?

The filter in the admin picker for proposal did not work. Fix it width backporting from decidim@6f5cc36

📌 Related Issues

Testing

Test dont needed because it is a backport

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

♥️ Thank you!

@microstudi
Copy link

Thanks @phoebus-84 , can you link the original PR in the decidim repostory please? thanks!

@phoebus-84
Copy link
Author

Sure but what do you mean exactly for original PR? These changes were backport from decidim/decidim:0.25-stable. Thanks!

@microstudi
Copy link

Yes, but a backport from a specific commit right? can you point me to it?

@phoebus-84
Copy link
Author

Yes, but a backport from a specific commit right? can you point me to it?

Thanks for the reply and there is it: decidim@6f5cc36

Copy link

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Before merging this, I see that the original commit had a javascript file affected as well. This file isn't relevant for the 0.24 version?

@phoebus-84
Copy link
Author

Thanks! Before merging this, I see that the original commit had a javascript file affected as well. This file isn't relevant for the 0.24 version?

That file was introduce here: decidim@05b8ee7 So I think it is not relevant for 0.24.

@microstudi
Copy link

This file exists in the 0.24 version. When migrated to 0.25 and webpacker, all JS files where moved to the packs directory.
You can find this file in decidim-proposals/app/assets/javascripts/decidim/proposals_picker.js.es6

@microstudi
Copy link

Thanks @phoebus-84, merging!

@microstudi microstudi merged commit 8de1ef8 into Platoniq:temp/0.24 Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants