-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport fixes for proposal picker #125
Conversation
Thanks @phoebus-84 , can you link the original PR in the decidim repostory please? thanks! |
Sure but what do you mean exactly for original PR? These changes were backport from decidim/decidim:0.25-stable. Thanks! |
Yes, but a backport from a specific commit right? can you point me to it? |
Thanks for the reply and there is it: decidim@6f5cc36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Before merging this, I see that the original commit had a javascript file affected as well. This file isn't relevant for the 0.24 version?
That file was introduce here: decidim@05b8ee7 So I think it is not relevant for 0.24. |
This file exists in the 0.24 version. When migrated to 0.25 and webpacker, all JS files where moved to the packs directory. |
Thanks @phoebus-84, merging! |
🎩 What? Why?
The filter in the admin picker for proposal did not work. Fix it width backporting from decidim@6f5cc36
📌 Related Issues
Testing
Test dont needed because it is a backport
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/
.📷 Screenshots