You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found some conflicting pin assignments in the globals.h file
I'll try to go through the ones that I found here:
1: In the "INSULATORS" and "CUBE" sections of globals.h, both LED_PIN0 and IR_REMOTE_PIN are defined to pin 26 - which would cause a conflict, right?
2: In Dave's videos where he uses the M5StickCplus, he said pin 32 should be assigned to LED_PIN0, (which is the very convenient yellow pin on the grove connector) - but this is inconsistently assigned to pin 26 in some places within globals.h. like FANSET, TREESET, HELMET, SINGLE_INSULATOR, etc.
in the DEMO section, it is defined with:
#if USE_M5
#define LED_PIN0 32
but in the SPECTRUM section, it is defaulted to pin 26 on lines 980 and 981 because no "#elif USE_M5 condition is present.
So, I would argue that an #if USE_M5 condition be added throughout to make sure pin 32 is assigned to all m5 projects consistently.
And a couple other issues.....
3: in globals.h, lines 309 through 315 are repeated on lines 320 through 316. (here, the m5 pin assignment is set to 32 as well)
4: in globals.h M5STICKC devices are assigned pin 33, (or 26 in SINGLE_INSULATOR) for LED_PIN0, but all other m5 devices are defined as 32. - (why the difference?)
The text was updated successfully, but these errors were encountered:
I found some conflicting pin assignments in the globals.h file
I'll try to go through the ones that I found here:
1: In the "INSULATORS" and "CUBE" sections of globals.h, both LED_PIN0 and IR_REMOTE_PIN are defined to pin 26 - which would cause a conflict, right?
2: In Dave's videos where he uses the M5StickCplus, he said pin 32 should be assigned to LED_PIN0, (which is the very convenient yellow pin on the grove connector) - but this is inconsistently assigned to pin 26 in some places within globals.h. like FANSET, TREESET, HELMET, SINGLE_INSULATOR, etc.
#if USE_M5
#define LED_PIN0 32
So, I would argue that an #if USE_M5 condition be added throughout to make sure pin 32 is assigned to all m5 projects consistently.
And a couple other issues.....
3: in globals.h, lines 309 through 315 are repeated on lines 320 through 316. (here, the m5 pin assignment is set to 32 as well)
4: in globals.h M5STICKC devices are assigned pin 33, (or 26 in SINGLE_INSULATOR) for LED_PIN0, but all other m5 devices are defined as 32. - (why the difference?)
The text was updated successfully, but these errors were encountered: