Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce and utilise treelib #20

Merged
merged 7 commits into from
Jul 18, 2021
Merged

Introduce and utilise treelib #20

merged 7 commits into from
Jul 18, 2021

Conversation

diivm
Copy link
Collaborator

@diivm diivm commented Jun 12, 2021 •
edited
Loading

Linking #21

@diivm diivm closed this Jun 12, 2021
@diivm diivm reopened this Jun 12, 2021
@diivm diivm changed the title Introduce and utilise [treelib](https://github.com/caesar0301/treelib) Introduce and utilise treelib Jun 12, 2021
kunaltyagi
kunaltyagi requested changes Jun 12, 2021
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I've seen this code before. Could you dedup it (and target the PR branch properly if that's the issue_?

@diivm
Copy link
Collaborator Author

diivm commented Jun 12, 2021

I feel like I've seen this code before. Could you dedup it (and target the PR branch properly if that's the issue_?

Branch created from the branch used at #6, needs merge

@diivm diivm force-pushed the devel/treelib branch 2 times, most recently from 82dafd7 to c06fa1a Compare June 23, 2021 20:28
kunaltyagi
kunaltyagi reviewed Jun 24, 2021
View reviewed changes
clang_bind/parse.py Outdated Show resolved Hide resolved
clang_bind/parse.py Show resolved Hide resolved
@diivm diivm force-pushed the devel/treelib branch 2 times, most recently from 0f65ebf to df6cd58 Compare July 3, 2021 17:08
@diivm
Copy link
Collaborator Author

diivm commented Jul 3, 2021

@kunaltyagi

The changes needed in the generate.py and test_generate.py will be a lot, will address them in another PR.

@diivm diivm marked this pull request as ready for review July 3, 2021 17:26
kunaltyagi
kunaltyagi reviewed Jul 5, 2021
View reviewed changes
.github/workflows/pytest.yml Show resolved Hide resolved
tests/test_parse.py Outdated Show resolved Hide resolved
clang_bind/parse.py Outdated Show resolved Hide resolved
@diivm diivm mentioned this pull request Jul 18, 2021
Open
@diivm diivm merged commit e60a5cc into PointCloudLibrary:master Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunaltyagi kunaltyagi kunaltyagi requested changes

Assignees
No one assigned
Labels
gsoc-2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diivm @kunaltyagi